chore: Run go generate to pick up mock changes#6277
Open
lukemassa wants to merge 4 commits intorunatlantis:mainfrom
Open
chore: Run go generate to pick up mock changes#6277lukemassa wants to merge 4 commits intorunatlantis:mainfrom
lukemassa wants to merge 4 commits intorunatlantis:mainfrom
Conversation
Signed-off-by: Luke Massa <lukefrederickmassa@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Regenerates Pegomock-generated mocks to align with recent interface signature updates (notably interface{} → any, plus the updated WorkingDirLocker.TryLock parameters) in the Atlantis server codebase.
Changes:
- Regenerated
SimpleLogging,TemplateWriter, andGitlabRequestParserValidatormocks to useanyin method signatures and captured-argument helpers. - Regenerated
WorkingDirLockermock to include theprojectName stringparameter in verifier/captured-argument helpers (matching the interface).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/logging/mocks/mock_simple_logging.go | Updates generated mock signatures and captured-argument helpers to use ...any. |
| server/events/mocks/mock_working_dir_locker.go | Updates generated mock/verifier argument handling to include projectName in TryLock. |
| server/controllers/web_templates/mocks/mock_template_writer.go | Updates generated mock signatures and captured-argument helpers to use any. |
| server/controllers/events/mocks/mock_gitlab_request_parser_validator.go | Updates generated mock return/capture typing to use any consistently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
Run
make go-generateto pick up mock changeswhy
#6056 was added without running
make go-generate.Note that initially pegomock did not respect the change from
interface{}toany, but this was fixed in petergtz/pegomock#117, so users may need to install the latest version of pegomock to verify.tests
None, CI should find any mock issues.
references
Finishing work started in: #6056