fix: show PR head branch instead of base branch in Slack notifications#6316
Open
kiwibel wants to merge 3 commits intorunatlantis:mainfrom
Open
fix: show PR head branch instead of base branch in Slack notifications#6316kiwibel wants to merge 3 commits intorunatlantis:mainfrom
kiwibel wants to merge 3 commits intorunatlantis:mainfrom
Conversation
Signed-off-by: Vadim Chausov <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Atlantis’ Slack apply notifications so the displayed branch corresponds to the PR’s head/source branch, aligning the message with what users typically care about when reviewing applies.
Changes:
- Slack attachment “Branch” field now uses
applyResult.Pull.HeadBranchinstead ofBaseBranch. - Updated Slack client test setup fixture to populate
HeadBranch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
server/events/webhooks/slack_client.go |
Changes the Slack attachment branch value to the PR head branch. |
server/events/webhooks/slack_client_test.go |
Adds HeadBranch to the ApplyResult test fixture data. |
Signed-off-by: Vadim Chausov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The base branch is almost always
main, which provides no useful context in Slack notifications. Showing the head branch instead makes it immediately clear which feature/fix was applied.Test plan
go test ./server/events/webhooks/...)TestCreateAttachments_HeadBranchto validate the Branch field value