test(events): synchronize saturated pool cancellation

[chenrui333]

What

Synchronize the saturated-pool cancellation test using worker events and synctest.

Why

The test must cancel while workers occupy the pool, without relying on scheduler timing.

Testing

100 race-enabled repetitions and the full events package, including -race, pass.

[Copilot]

🟡 Changes recommended

The updated test can leak/hang under synctest if a require.* assertion fails before unblocking worker goroutines; it should close the release channel via t.Cleanup (with sync.Once) to ensure cleanup on early exits.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the server/events test suite to make the “saturated worker pool cancellation” scenario deterministic by synchronizing goroutine progress using worker events and testing/synctest, rather than relying on scheduler timing.

Changes:

• Reworks TestRunProjectCmdsParallel_CancelledWhileExceedingPoolSize to block the first two workers explicitly and trigger cancellation while the submitter is blocked in wg.Add().
• Uses synctest.Wait() to ensure the test reaches the intended blocked state before cancelling and unblocking.

File summaries

File	Description
server/events/project_command_pool_executor_test.go	Makes the saturated-pool cancellation test deterministic using synctest and worker synchronization channels.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-code-quality]

Code Coverage Overview

Languages: Go

Go / code-coverage/go

The overall line coverage in commit c3d7b48 in the test/saturated-pool-... branch is 73%. Line coverage data for the main branch is not yet available.

Show a line coverage summary of the most covered files.

File	main	test/saturated-pool-... c3d7b48	+/-
server/events/v...ithub/client.go	—	88%	—
server/core/ter...aform_client.go	—	88%	—
server/controll...i_controller.go	—	83%	—
server/events/p...mand_builder.go	—	83%	—
server/events/v...itlab/client.go	—	80%	—
server/events/p...mmand_runner.go	—	76%	—
server/events/event_parser.go	—	76%	—
server/events/working_dir.go	—	73%	—
server/server.go	—	70%	—
server/controll...s_controller.go	—	64%	—

---

_{Updated September 07, 2026 23:55 UTC}