test(runtime): cover subprocess execution failures

[chenrui333]

What

Cover command output and typed errors on subprocess execution and startup failures.

Why

A regression could discard stderr or the exit cause while existing happy-path tests still passed.

Testing

Focused subprocess cases and the full models package pass with -race and coverage.

[Copilot]

🟡 Changes recommended

The new test uses a non-existent errors.AsType helper and will not compile without switching to errors.As.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds regression coverage in the runtime command runner tests to ensure subprocess startup/exit failures preserve both combined output (stdout+stderr) and typed error causes, preventing regressions where stderr or exit information is lost.

Changes:

• Add test coverage for non-zero exit handling (including preserving stdout/stderr output).
• Add test coverage for command start failures (missing executable / missing working directory) and verify error context.

File summaries

File	Description
server/core/runtime/models/shell_command_runner_test.go	Adds tests for subprocess exit/start failure cases to validate output capture and error typing/context.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-code-quality]

Code Coverage Overview

Languages: Go

Go / code-coverage/go

The overall line coverage in commit 3a876bd in the test/subprocess-fail... branch is 73%. Line coverage data for the main branch is not yet available.

Show a line coverage summary of the most covered files.

File	main	test/subprocess-fail... 3a876bd	+/-
server/events/v...ithub/client.go	—	88%	—
server/core/ter...aform_client.go	—	88%	—
server/controll...i_controller.go	—	83%	—
server/events/p...mand_builder.go	—	83%	—
server/events/v...itlab/client.go	—	80%	—
server/events/p...mmand_runner.go	—	76%	—
server/events/event_parser.go	—	76%	—
server/events/working_dir.go	—	73%	—
server/server.go	—	70%	—
server/controll...s_controller.go	—	64%	—

---

_{Updated September 08, 2026 00:02 UTC}