Skip to content

fix(domainregister): compare email domain quota numerically#1997

Open
tzh476 wants to merge 3 commits into
runbox:masterfrom
tzh476:tzh476/domain-quota-numeric-1994
Open

fix(domainregister): compare email domain quota numerically#1997
tzh476 wants to merge 3 commits into
runbox:masterfrom
tzh476:tzh476/domain-quota-numeric-1994

Conversation

@tzh476

@tzh476 tzh476 commented Jul 18, 2026

Copy link
Copy Markdown

Summary

Fix #1994 by normalizing the email-domain quota values before comparing them. This prevents numeric strings such as 7 and 20 from being compared lexicographically and incorrectly tripping the quota-limit path.

The PR keeps the regression test in its own commit, followed by the fix commit, so the test can be cherry-picked independently.

Duplicate check

Validation

  • npx tsc -p src/tsconfig.spec.json --noEmit
  • npm run lint -- --quiet
  • git diff --check HEAD~2..HEAD

Not run locally:

  • npm run ci-tests: this environment does not currently have a working Firefox/Karma browser runtime available, so I kept validation to the static checks above instead of reporting full CI coverage.

AI-use disclosure

This contribution was prepared with AI assistance.

  • Model/agent: OpenAI Codex, GPT-5 based coding agent.
  • Harness: Codex desktop/local shell environment; exact harness version not shown in the session.
  • Tools used for this PR: local shell commands, npm/TypeScript/Angular lint tooling, GitHub CLI.
  • Available installed connector/plugin classes in the session included GitHub, Gmail, Chrome/browser, and document/data tooling; only local shell and GitHub CLI were used to prepare and submit this PR.
  • AI touched the issue analysis, regression test, implementation, validation commands, commit preparation, and PR description.
  • The account owner reviewed/approved submission in the Codex task before this PR was opened.

tzh476 added 3 commits July 19, 2026 04:30
Add a regression spec for runbox#1994 that keeps availability lookup open when quota counts arrive as numeric strings below the allowed limit.

Change-Id: I855782e00e34af19e9c8cc300122bd6c4c7cb649
Normalize the domain quota values from the API before comparing them so string counts such as 7 of 20 do not trip the quota limit path for runbox#1994.

Change-Id: Ia772aa1bbf987cc60248252a1b4a0df9a7dcfeea
Change-Id: I65619388cc5a1442e7d0f56d4bc1f043dbf3f567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#Domains New domains can't be registerd because the Email Domain quota is incorrectly calculated

1 participant