fix(domainregister): compare email domain quota numerically#1997
Open
tzh476 wants to merge 3 commits into
Open
fix(domainregister): compare email domain quota numerically#1997tzh476 wants to merge 3 commits into
tzh476 wants to merge 3 commits into
Conversation
Add a regression spec for runbox#1994 that keeps availability lookup open when quota counts arrive as numeric strings below the allowed limit. Change-Id: I855782e00e34af19e9c8cc300122bd6c4c7cb649
Normalize the domain quota values from the API before comparing them so string counts such as 7 of 20 do not trip the quota limit path for runbox#1994. Change-Id: Ia772aa1bbf987cc60248252a1b4a0df9a7dcfeea
Change-Id: I65619388cc5a1442e7d0f56d4bc1f043dbf3f567
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #1994 by normalizing the email-domain quota values before comparing them. This prevents numeric strings such as
7and20from being compared lexicographically and incorrectly tripping the quota-limit path.The PR keeps the regression test in its own commit, followed by the fix commit, so the test can be cherry-picked independently.
Duplicate check
1994,domain quota, andEmail Domain quota.Validation
npx tsc -p src/tsconfig.spec.json --noEmitnpm run lint -- --quietgit diff --check HEAD~2..HEADNot run locally:
npm run ci-tests: this environment does not currently have a working Firefox/Karma browser runtime available, so I kept validation to the static checks above instead of reporting full CI coverage.AI-use disclosure
This contribution was prepared with AI assistance.