fix: conflict in parsing of -h flag for help and hostname in container run - #1251
Merged
Merged
Conversation
pendo324
reviewed
Jan 21, 2025
austinvazquez
left a comment
Contributor
There was a problem hiding this comment.
So this [nerdctlCommand.run] must be the infamous parsing function that CLI folks refer to that is long overdue for refactor. I don't have any recommendations today so no reason to block this but it does feel odd to me and difficult to maintain.
chews93319
reviewed
Jan 21, 2025
Shubhranshu153
force-pushed
the
fix-hostname
branch
from
January 22, 2025 13:35
1ef973f to
3449105
Compare
…r run Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
Shubhranshu153
force-pushed
the
fix-hostname
branch
from
January 22, 2025 13:41
3449105 to
c96db80
Compare
chews93319
approved these changes
Jan 22, 2025
pendo324
approved these changes
Jan 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…r run
Issue #, if available:
Description of changes:
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.