Conversation
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
…ort for certificates if vars configured.
…iguration, validation for cert configs that work together missing counterparts.
…organized env vars for ca list.
…e console.log was used before.
Murike
force-pushed
the
feature/custom-certificate
branch
from
9efedad to
e797828
Compare
…stom HttpClients if ever provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
(TS SDK Parity Effort) Missing - Proper support custom SSL/CA certificates
[sc-53845] - https://app.shortcut.com/galileo/story/53845/ts-sdk-parity-effort-missing-proper-support-custom-ssl-ca-certificates
Description
Generated description
Below is a concise technical summary of the changes proposed in this PR:
graph LR initHooks_("initHooks"):::modified CertManagementHook_("CertManagementHook"):::added CertManagementHook_sdkInit_("CertManagementHook.sdkInit"):::added GalileoConfig_("GalileoConfig"):::modified getCertConfig_("getCertConfig"):::added UNDICI_("UNDICI"):::added FILE_SYSTEM_("FILE_SYSTEM"):::added NODE_RUNTIME_("NODE_RUNTIME"):::added initHooks_ -- "Registers CertManagementHook to enable TLS certificate management." --> CertManagementHook_ CertManagementHook_sdkInit_ -- "Uses GalileoConfig.get() to read resolved config including certs." --> GalileoConfig_ CertManagementHook_sdkInit_ -- "Retrieves CA/client certs and rejectUnauthorized flag." --> getCertConfig_ CertManagementHook_sdkInit_ -- "Creates undici.Agent dispatcher with TLS connect options." --> UNDICI_ CertManagementHook_sdkInit_ -- "Reads certificate and key files from filesystem for TLS." --> FILE_SYSTEM_ CertManagementHook_sdkInit_ -- "Checks Node.js version for Request.dispatcher compatibility warnings." --> NODE_RUNTIME_ classDef added stroke:#15AA7A classDef removed stroke:#CD5270 classDef modified stroke:#EDAC4C linkStyle default stroke:#CBD5E1,font-size:13pxImplements custom SSL/CA certificate support by introducing a
CertManagementHookthat configures anundicidispatcher for the SDK'sHTTPClient. Enhances theGalileoConfigcomponent to resolve certificate paths, content, and validation settings from environment variables to achieve parity with the TS SDK.Latest Contributors(2)