Skip to content

fix(url): Base URL recovered from env var is automatically integrated into SDK initialization, instead of relying on being passed during requests. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Murike merged 2 commits into from
Mar 12, 2026
Merged

fix(url): Base URL recovered from env var is automatically integrated into SDK initialization, instead of relying on being passed during requests. #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcca8fe
fix(url): Base URL recovered from env var is automatically integrated…
Murike Mar 10, 2026
4a36f17
fix(comment): Updated comment to reflect the file is not 100% Speakea…
Murike Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/lib/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
/*
* Code generated by Speakeasy (https://speakeasy.com). DO NOT EDIT.
* @generated-id: 320761608fb3
* Code originally generated by Speakeasy (https://speakeasy.com).
* 03-11-2026 - Modified by Galileo to add a new source for API URL path.
*/

import { Params, pathToFunc } from "./url.js";
import { HTTPClient } from "./http.js";
import { Logger } from "./logger.js";
import { RetryConfig } from "./retries.js";
import { Params, pathToFunc } from "./url.js";
import { GalileoConfig } from "./galileo-config.js";

/**
* Contains the list of servers available to the SDK
Expand Down Expand Up @@ -43,7 +44,8 @@ export type SDKOptions = {
};

export function serverURLFromOptions(options: SDKOptions): URL | null {
let serverURL = options.serverURL;
const config = GalileoConfig.get();
let serverURL = options.serverURL ?? config.apiUrl;
Copy link

@fernandocorreia-galileo fernandocorreia-galileo Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the type of apiUrl is apiUrl: string | undefined, is it possible that serverURL will be undefined? Can this happen in practice?

Copy link
Contributor Author

@Murike Murike Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only way this could happen was if no url was provided in "options" and ServerList is also empty, I believe Speakeasy assigns "string | undefined" as the type here to support this possibility.
Since config.apiUrl will (in the worst case) provide the default "https://api.galileo.ai" URL, not likely to happen now (compiler/lint rules could not figure that this is the case, so I'm maintaining the type for proper support).


const params: Params = {};

Expand Down
Loading