修复活动无法刷活动票任务，增加自动切换门票，100体，体力爬塔活动任务；结界式神添加智能放入；增加每日任务的一键收菜#1522
Closed
rwerplus wants to merge 30 commits into
Closed
修复活动无法刷活动票任务，增加自动切换门票，100体，体力爬塔活动任务；结界式神添加智能放入；增加每日任务的一键收菜#1522rwerplus wants to merge 30 commits into
rwerplus wants to merge 30 commits into
Conversation
…, improve OCR handling, and introduce daily free ticket popup processing.
…igami management, with assets and task flow enhancements.
Contributor
Author
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
你好，我在下面给出了一些高层面的反馈：
_goto_main_battlefield中包含一个while 1循环：如果在main_clicks < max_main_clicks的情况下，一直没有检测到任何一个被跟踪的锚点（I_CHECK_BATTLE_MAIN/_2、I_TO_BATTLE_MAIN_2、I_TO_BATTLE_MAIN），那么循环体可能会在不增加计数器、也不休眠的情况下空转；建议添加sleep调用和/或额外的退出条件，以避免在意料之外的 UI 上出现紧密的无限循环。- 默认配置 profile 在 ActivityShikigami 和 DailyTrifles 的测试/入口代码中都从 “oas1” 改成了 “欢哥”；如果这是用户或环境相关的设置，最好改为可配置，或者保持一个中性的默认值，以避免把某个开发者的个人 profile 写死在代码里。
面向 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- _goto_main_battlefield contains a `while 1` loop where, if none of the tracked anchors (I_CHECK_BATTLE_MAIN/_2, I_TO_BATTLE_MAIN_2, I_TO_BATTLE_MAIN) appear and `main_clicks < max_main_clicks`, the body can spin without incrementing counters or sleeping; consider adding a sleep and/or an additional escape condition to avoid a tight infinite loop on unexpected UIs.
- The default config profile has been changed from 'oas1' to '欢哥' in both ActivityShikigami and DailyTrifles test/entry code; if this is user- or environment-specific, it would be better to make it configurable or keep a neutral default to avoid hardcoding one developer's profile.帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈来改进后续的审查。
Original comment in English
Hey - I've left some high level feedback:
- _goto_main_battlefield contains a
while 1loop where, if none of the tracked anchors (I_CHECK_BATTLE_MAIN/_2, I_TO_BATTLE_MAIN_2, I_TO_BATTLE_MAIN) appear andmain_clicks < max_main_clicks, the body can spin without incrementing counters or sleeping; consider adding a sleep and/or an additional escape condition to avoid a tight infinite loop on unexpected UIs. - The default config profile has been changed from 'oas1' to '欢哥' in both ActivityShikigami and DailyTrifles test/entry code; if this is user- or environment-specific, it would be better to make it configurable or keep a neutral default to avoid hardcoding one developer's profile.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- _goto_main_battlefield contains a `while 1` loop where, if none of the tracked anchors (I_CHECK_BATTLE_MAIN/_2, I_TO_BATTLE_MAIN_2, I_TO_BATTLE_MAIN) appear and `main_clicks < max_main_clicks`, the body can spin without incrementing counters or sleeping; consider adding a sleep and/or an additional escape condition to avoid a tight infinite loop on unexpected UIs.
- The default config profile has been changed from 'oas1' to '欢哥' in both ActivityShikigami and DailyTrifles test/entry code; if this is user- or environment-specific, it would be better to make it configurable or keep a neutral default to avoid hardcoding one developer's profile.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
一键收菜重启任务里已经有了 |
Contributor
Author
一直没看到呢，可能我的客户端没更新呢 |
Owner
|
太多了，你让ai拆分成几个pr |
Change Summary
Reconstructed Intent点击此处展开
Observed Constraints点击此处展开
Intent Alignment
Release Risk
Validation Gaps点击此处展开
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
通过增强活动爬塔自动化中的票券/体力处理、支持 AP100、优化战斗流程，并为结界添加智能式神摆放以及新增一键庭院收菜日常任务。
New Features:
Bug Fixes:
Enhancements:
Original summary in English
Summary by Sourcery
Enhance activity climb automation with robust ticket/stamina handling, AP100 support, and smarter battle flows, while adding smart shikigami placement for Kekkai and a new one-tap courtyard harvest daily task.
New Features:
Bug Fixes:
Enhancements: