Dev UI 1533

[runhey]

由 Sourcery 提供的摘要

更新 UI 自动化资源定义，使其与修订后的游戏内布局保持一致，并提升在多项任务中的检测/交互稳定性。

改进内容：

• 调整 Game UI exploration、town 和 main-page 入口的图像、点击、列表和 OCR 区域，使其与当前屏幕位置相匹配。
• 重新校准 Sougenbi、EvoZone、GoryouRealm、FallenSun、Orochi 和 EternitySea 的资源坐标和列表布局，以更可靠地识别和点击副本入口、锁定标记以及挑战按钮。
• 更新与这些任务相关的 JSON 资源元数据，以与新的屏幕区域保持一致。

Original summary in English

Summary by Sourcery

Update UI automation asset definitions to align with revised in-game layouts and improve detection/interaction reliability across multiple tasks.

Enhancements:

• Adjust image, click, list, and OCR regions for Game UI exploration, town, and main-page entries to match current screen positions.
• Retune Sougenbi, EvoZone, GoryouRealm, FallenSun, Orochi, and EternitySea asset coordinates and list layouts for more robust recognition and clicking of dungeon entries, locks, and challenge buttons.
• Update associated JSON asset metadata for these tasks to stay consistent with the new on-screen regions.

[sourcery-ai]

Hey - 我在这里给出了一些高层次的反馈：

• 现在有很多 ROI 和阈值被硬编码并在不同资源之间重复（例如，各种锁定/解锁按钮和开火按钮都集中在 x≈700 / x≈1100 一带）；建议将这些共享坐标进行集中管理，或者从一个通用的布局辅助工具中派生出来，这样当 UI 再次变动时，可以降低维护成本。
• 有几个阈值被放宽了（例如 MAIN_GOTO_MALL 从 0.7 降到 0.5，MAIN_GOTO_DAILY 降到 0.6）；如果这是为了补偿模板变得更嘈杂，那么与其依赖更低的相似度得分（容易导致误报），可能更值得收紧 ROI 或模板图像本身。
• 对于那些 roi_front 和 roi_back 在尺寸或位置上出现较大差异的规则，建议保持一个一致的约定（例如，roi_front 严格包住图标本身，roi_back 则作为一个更稳定、更宽泛的区域），这样未来对 ROI 的调整会更容易理解、也更不容易出错。

给 AI Agent 的提示

Please address the comments from this code review:

## Overall Comments
- A lot of ROI and threshold values are now hard-coded and duplicated across assets (e.g., various lock/unlock and fire buttons around x≈700 / x≈1100); consider centralizing these shared coordinates or deriving them from a common layout helper to reduce maintenance overhead when the UI shifts again.
- Several thresholds were relaxed (e.g., MAIN_GOTO_MALL from 0.7 to 0.5, MAIN_GOTO_DAILY to 0.6); if these are compensating for noisier templates, it may be worth tightening the ROI or template images instead of relying on much lower similarity scores to avoid false positives.
- For rules where roi_front and roi_back now differ significantly in size or position, it would help to keep a consistent convention (e.g., roi_front tightly around the icon, roi_back as a stable wider region) so future ROI adjustments are easier to reason about and less error-prone.

---

Sourcery 对开源项目是免费的——如果你觉得我们的评审有帮助，欢迎分享 ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{请帮我变得更有用！请对每条评论点 👍 或 👎，我会利用这些反馈改进后续的评审质量。}

Original comment in English

Hey - I've left some high level feedback:

• A lot of ROI and threshold values are now hard-coded and duplicated across assets (e.g., various lock/unlock and fire buttons around x≈700 / x≈1100); consider centralizing these shared coordinates or deriving them from a common layout helper to reduce maintenance overhead when the UI shifts again.
• Several thresholds were relaxed (e.g., MAIN_GOTO_MALL from 0.7 to 0.5, MAIN_GOTO_DAILY to 0.6); if these are compensating for noisier templates, it may be worth tightening the ROI or template images instead of relying on much lower similarity scores to avoid false positives.
• For rules where roi_front and roi_back now differ significantly in size or position, it would help to keep a consistent convention (e.g., roi_front tightly around the icon, roi_back as a stable wider region) so future ROI adjustments are easier to reason about and less error-prone.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- A lot of ROI and threshold values are now hard-coded and duplicated across assets (e.g., various lock/unlock and fire buttons around x≈700 / x≈1100); consider centralizing these shared coordinates or deriving them from a common layout helper to reduce maintenance overhead when the UI shifts again.
- Several thresholds were relaxed (e.g., MAIN_GOTO_MALL from 0.7 to 0.5, MAIN_GOTO_DAILY to 0.6); if these are compensating for noisier templates, it may be worth tightening the ROI or template images instead of relying on much lower similarity scores to avoid false positives.
- For rules where roi_front and roi_back now differ significantly in size or position, it would help to keep a consistent convention (e.g., roi_front tightly around the icon, roi_back as a stable wider region) so future ROI adjustments are easier to reason about and less error-prone.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

Change Summary

• 针对 EternitySea、EvoZone、FallenSun 三个副本的 assets.py、JSON 元数据、PNG 资源进行了全面坐标重校准
• 锁图标 ROI 从 x≈557 移到 x≈699-700(幅度约 140px)
• 入口图标 roiFront 从大区域(如 784,113,290,396)改为精确小区域(如 881,100,58,65)
• List OCR 区域从水平布局(roiBack 138,130,359,500)改为竖向布局(124,84,77,632)
• 同步更新了对应的 PNG 资源文件

Reconstructed Intent

点击此处展开

- 这次改动最可能是应对游戏客户端 UI 布局更新后的资产重校准 - 游戏内各个副本的入口位置、锁定图标位置、挑战按钮位置发生了整体偏移 - 改动规模覆盖 6 个任务(EternitySea、EvoZone、FallenSun、Sougenbi、GoryouRealm、Orochi),属于跨任务协调变更

Observed Constraints

点击此处展开

- **依赖游戏版本稳定性**:资产坐标与特定游戏客户端版本绑定,客户端更新后可能再次失效 - **ROI 语义变化**:部分入口图标的 roiFront 从"大区域匹配"变为"精确小区域匹配",匹配逻辑发生变化 - **PNG 资源同步**:ROI 调整需要同步更新对应的 PNG 模板图,缺少一方会导致匹配失败 - **多任务一致性**:多个任务同时调整,但未看到统一的坐标变换规则或相对位移记录

Intent Alignment

• 实现与推断 intent 基本一致:坐标重校准覆盖了锁图标、入口、挑战按钮、列表识别等关键元素
• Entry icon 的 roiFront 从大区域改为精确小区域,与"适应新游戏布局"的 intent 匹配
• JSON 元数据与 assets.py 的 ROI 同步更新,保持一致性

Release Risk

• 风险等级:中
• 跨任务耦合风险:6 个任务的资产同时调整,若其中某个任务的新坐标仍有偏差,可能在特定层数或网络延迟下触发识别失败
• 游戏版本绑定:若游戏客户端尚未统一推送,测试环境与实际用户环境可能存在 UI 偏差
• PNG 资源精度:入口图标从小 roiFront 改为精确匹配,对 PNG 模板清晰度要求更高,模板老化或模糊可能引入检测不稳定

Validation Gaps

点击此处展开

- 未看到对每个任务新 ROI 的实际识别率/点击成功率验证数据 - 未看到跨任务协调变更的一致性检查说明(例如:锁图标从 x=557 移到 x=699,是否所有任务的锁图标都移动了约 140px,还是每任务独立测量) - 未看到游戏客户端版本或屏幕分辨率兼容性说明(1920x1080?其他分辨率?) - PNG 资源更新后的模板质量未经验证

Generated by PR Review Intent for issue #1534 · ● 143.9K · ◷

[github-actions]

Findings

• 未发现未通过项

Generated by PR Review Checklist for issue #1534 · ● 1.2M · ◷

[LGG686]

觉醒部分的各个麒麟需要调整下，带花车的部分需要截掉