Revert "梦虚秘境支持PVP"

[runhey]

Summary by Sourcery

恢复与 PVP 相关的技能处理改动，同时调整探索、Orochi、英雄试炼和通缉任务界面的各类 UI 素材模板及检测逻辑。

Enhancements:

• 更新多个游戏 UI 和 Orochi 图像资源的 ROI 配置，使其与当前布局保持一致。
• 在移除 PVP 专属技能后，优化英雄试炼技能资源定义及其选择列表。
• 将通缉任务剩余任务检测方式从基于 OCR 改为基于图像识别，并使用新的标记资源。
• 从代码仓库中移除已废弃的技能图片自动更新器相关文档文件。

Original summary in English

Summary by Sourcery

Revert PVP-related skill handling changes and adjust various UI asset templates and detection logic for exploration, Orochi, Hero Test, and Wanted Quests screens.

Enhancements:

• Update ROI configurations for multiple Game UI and Orochi image assets to match current layouts.
• Refine Hero Test skill asset definitions and selection lists after removing PVP-specific skills.
• Change Wanted Quests remaining-task detection from OCR-based to image-based using a new marker asset.
• Remove obsolete skill image auto-updater documentation artifact from the repository.

[sourcery-ai]

Hey - 我给出了一些整体性的反馈：

• 在 hero2_skill_wait 中，pvp_skill 现在是一个空列表，但仍然通过 SkillMode.PVP 被引用；建议要么对 PVP 模式做防护，要么恢复一个最小的后备技能集合，以避免在运行时变成空操作行为。
• 将 I_HERO2_SKILL6 重新指向之前的 I_HERO2_SKILL7 资源会改变它的语义含义；请再次检查所有使用 I_HERO2_SKILL6 的调用点，以确保在本次回滚之后，它们仍然指向预期的技能（加速祝福）。
• 从 OCR（O_WQ_LIST_TOP_BOTTOM_CHECK）切换到基于图片的检测（I_WQ_LIST_TOP_BOTTOM_CHECK）来检查剩余的通缉任务，会改变检测条件；建议简单验证一下，在边缘 UI 状态（例如空列表、部分滚动）下，is_wq_remained 仍然能够正确区分任务存在/不存在。

面向 AI 代理的提示

Please address the comments from this code review:

## Overall Comments
- In `hero2_skill_wait`, `pvp_skill` is now an empty list while still being referenced via `SkillMode.PVP`; consider either guarding against PVP mode or restoring a minimal fallback set of skills to avoid runtime no-op behavior.
- The reassignment of `I_HERO2_SKILL6` to point at the former `I_HERO2_SKILL7` asset changes its semantic meaning; double-check all call sites using `I_HERO2_SKILL6` to ensure they still refer to the intended skill (speed blessing) after this revert.
- The switch from OCR (`O_WQ_LIST_TOP_BOTTOM_CHECK`) to image-based detection (`I_WQ_LIST_TOP_BOTTOM_CHECK`) for checking remaining wanted quests changes the detection conditions; consider briefly validating that `is_wq_remained` still correctly distinguishes the presence/absence of tasks in edge UI states (e.g., empty list, partially scrolled).

---

Sourcery 对开源项目是免费的——如果你觉得我们的评审有帮助，欢迎分享 ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{帮我变得更有用！请对每条评论点 👍 或 👎，我会根据反馈改进后续评审。}

Original comment in English

Hey - I've left some high level feedback:

• In hero2_skill_wait, pvp_skill is now an empty list while still being referenced via SkillMode.PVP; consider either guarding against PVP mode or restoring a minimal fallback set of skills to avoid runtime no-op behavior.
• The reassignment of I_HERO2_SKILL6 to point at the former I_HERO2_SKILL7 asset changes its semantic meaning; double-check all call sites using I_HERO2_SKILL6 to ensure they still refer to the intended skill (speed blessing) after this revert.
• The switch from OCR (O_WQ_LIST_TOP_BOTTOM_CHECK) to image-based detection (I_WQ_LIST_TOP_BOTTOM_CHECK) for checking remaining wanted quests changes the detection conditions; consider briefly validating that is_wq_remained still correctly distinguishes the presence/absence of tasks in edge UI states (e.g., empty list, partially scrolled).

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In `hero2_skill_wait`, `pvp_skill` is now an empty list while still being referenced via `SkillMode.PVP`; consider either guarding against PVP mode or restoring a minimal fallback set of skills to avoid runtime no-op behavior.
- The reassignment of `I_HERO2_SKILL6` to point at the former `I_HERO2_SKILL7` asset changes its semantic meaning; double-check all call sites using `I_HERO2_SKILL6` to ensure they still refer to the intended skill (speed blessing) after this revert.
- The switch from OCR (`O_WQ_LIST_TOP_BOTTOM_CHECK`) to image-based detection (`I_WQ_LIST_TOP_BOTTOM_CHECK`) for checking remaining wanted quests changes the detection conditions; consider briefly validating that `is_wq_remained` still correctly distinguishes the presence/absence of tasks in edge UI states (e.g., empty list, partially scrolled).

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[github-actions]

Findings

• C1 [风险]
  位置:PR 整体
  原因:标题为 revert "梦虚秘境支持PVP",但实际改动除 HeroTest PVP 技能回退外,还包含 GameUi/Orochi 多处 ROI 配置更新、PNG 素材更新,超出单纯回退范围,属于把多个独立改动打包。
  修改:将纯 PVP revert 内容与其他 UI 调整拆分,分别提交。

• C2 [风险]
  位置:tasks/HeroTest/script_task.py:hero2_skill_wait()
  原因:pvp_skill 列表已清空且仅有 # TODO: PVP 注释。当外部调用 SkillMode.PVP 时会进入 hero2_skill_wait,但拿到空列表,逻辑上无明确退出条件(无重试、超时或报错),存在静默卡住风险。
  修改:若暂不支持 PVP,应在 SkillMode.PVP 分支添加明确注释或抛出异常,而不是隐式返回空列表。

Generated by PR Review Checklist for issue #1535 · ● 172.1K · ◷