Fix/clientid follows livestore best practices#481
Merged
Conversation
- Update sync payload schema to include optional userId
- Generate unique clientId per device instance using userId-{uuid} pattern
- Add backward compatibility for existing clients without userId
- Update validation logic to check userId instead of clientId for user attribution
- Follow same pattern as runt runtime agent (PR #209)
Fixes the incorrect practice of setting clientId = userId, which violates
LiveStore's design where clientId should identify device/app instances.
The backend already validates the JWT and knows the user identity from validatedUser.id. Trusting client-provided userId was a security vulnerability where malicious clients could potentially impersonate other users by passing different userId values. Now the backend only uses the JWT-validated user identity, which is secure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anode side of nteract/desktop#209