Implement stdin input_request test#4
Merged
Merged
Conversation
- Add execute_with_stdin() helper to harness that handles input requests - Polls both IOPub and stdin channels during execution - Sends mock input_reply when input_request is received - Sets allow_stdin=true in execute request to enable stdin handling - Test verifies kernel sends input_request and completes execution ipykernel now passes 4/5 Tier 4 tests (only comms_lifecycle still skipped).
Kernel Conformance Matrix
deno (Deno kernel) - 3 failures, 3 skippedLanguage: typescript | Protocol: 5.3 Failures
Skipped (Not Implemented)
evcxr (evcxr_jupyter) - 5 failures, 3 skippedLanguage: Rust | Protocol: 5.3 Failures
Skipped (Not Implemented)
ipykernel (ipython) - 0 failures, 1 skippedLanguage: python | Protocol: 5.3 Skipped (Not Implemented)
Test Results by Message Type
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the previously-stubbed stdin test to validate that kernels properly handle input requests during execution.
Changes:
execute_with_stdin()helper to harness that:allow_stdin=truein execute requestinput_requestwith mockinput_replytest_stdin_input_requestto verify:input_requestwhen code needs inputResults:
comms_lifecycleremains as a stubTest plan