Implement comms_lifecycle test#5
Merged
Merged
Conversation
- Add send_comm_open() and send_comm_close() helpers to harness - Test sends comm_open with test target, checks for rejection or acceptance - Verifies kernel remains responsive after comm operations - ipykernel now passes 5/5 Tier 4 tests (100%) The test handles both scenarios: - Kernel rejects unknown target with comm_close (proper behavior) - Kernel accepts/ignores the comm (also valid, we clean up and verify responsiveness)
Kernel Conformance Matrix
deno (Deno kernel) - 3 failures, 2 skippedLanguage: typescript | Protocol: 5.3 Failures
Skipped (Not Implemented)
evcxr (evcxr_jupyter) - 5 failures, 2 skippedLanguage: Rust | Protocol: 5.3 Failures
Skipped (Not Implemented)
Test Results by Message Type
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the comms_lifecycle test to validate kernel comm handling.
Changes:
send_comm_open()helper that sends comm_open and checks for rejectionsend_comm_close()helper to clean up commsResults:
Test plan