Conversation
Deno.jupyter.html is a tagged template literal, not a function. Using function call syntax caused display_data test to fail.
Uses Deno.jupyter.broadcast API for TypeScript and IPython.display update_display for Python. Tests that kernels can send initial display_data with display_id, then send update_display_data to modify it.
evcxr uses println!("EVCXR_BEGIN_CONTENT mime/type\n...\nEVCXR_END_CONTENT")
for rich output. Also fixed R and Julia comments to use # syntax.
Kernel Conformance Matrix
deno (Deno kernel) - 3 failures, 2 skippedLanguage: typescript | Protocol: 5.3 Failures
Skipped (Not Implemented)
evcxr (evcxr_jupyter) - 5 failures, 2 skippedLanguage: Rust | Protocol: 5.3 Failures
Skipped (Not Implemented)
Test Results by Message Type
|
Kernel Conformance Matrix
deno (Deno kernel) - 3 failures, 2 skippedLanguage: typescript | Protocol: 5.3 Failures
Skipped (Not Implemented)
evcxr (evcxr_jupyter) - 5 failures, 3 skippedLanguage: Rust | Protocol: 5.3 Failures
Skipped (Not Implemented)
Test Results by Message Type
|
1 similar comment
Kernel Conformance Matrix
deno (Deno kernel) - 3 failures, 2 skippedLanguage: typescript | Protocol: 5.3 Failures
Skipped (Not Implemented)
evcxr (evcxr_jupyter) - 5 failures, 3 skippedLanguage: Rust | Protocol: 5.3 Failures
Skipped (Not Implemented)
Test Results by Message Type
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves rich output testing for multiple kernels by fixing display_data snippets and adding update_display_data support.
Changes
Deno (TypeScript)
display_data_codeto use tagged template literal syntax:update_display_data_codeusingDeno.jupyter.broadcast("display_data", ...)andDeno.jupyter.broadcast("update_display_data", ...)withdisplay_idevcxr (Rust)
display_data_codeusing evcxr's native protocol:update_display_data(no display_id support in their protocol)Python (ipykernel)
update_display_data_codeusingIPython.display.update_display()withdisplay_idNew Test
update_display_datatest (Tier 3) that verifies:display_datawith adisplay_idupdate_display_datato modify the existing displayResearch Notes
EVCXR_BEGIN_CONTENT/EVCXR_END_CONTENTmarkers for rich output. Can useevcxr_runtime::mime_type()helper if dependency is added, but rawprintln!works without deps.Deno.jupyter.htmlis a tagged template literal, not a function. For dynamic display updates, useDeno.jupyter.broadcast().Test plan