Pull out all Deno APIs from lib, making it fully browser compatible#207
Merged
Pull out all Deno APIs from lib, making it fully browser compatible#207
lib, making it fully browser compatible#207Conversation
- Move auth.ts from lib to pyodide-runtime-agent - Extract CLI parsing functions from lib/config.ts to pyodide-runtime-agent/config-cli.ts - Keep RuntimeConfig class and DEFAULT_CONFIG in lib as pure data structures - Update lib exports to remove CLI/auth functions - Move config tests to pyodide package - Add --allow-sys flag to lib tests for hostname access - Update pyodide package to import auth and CLI functions locally This makes lib platform-agnostic while keeping all CLI/Deno-specific logic in the pyodide runtime agent.
- Remove unused parameter in test helper - Remove unused import from pyodide config - Fix python runtime agent to use dummy config and not exit in tests - Update python runtime agent to show clear not-implemented message
- Move signal handling from RuntimeAgent to PyodideRuntimeAgent - Make RuntimeAgent setupShutdownHandlers/cleanupShutdownHandlers extensible - Add triple-slash directive to logging test instead of global compiler option - Keep lib package truly platform-agnostic with only DOM and ESNext libs - Fix test expectation to match localhost URL from .env override The lib package is now completely platform-agnostic - all Deno-specific code has been moved to the pyodide-runtime-agent package.
The test now works in both local dev (with .env localhost override) and CI (with default rgbkrk URL) environments by checking for either localhost or a valid WebSocket URL pattern.
Tests should run in clean environments for proper isolation. The --env-file=.env flag was causing tests to inherit local development configuration, making them environment-dependent. Now tests get the true default values and run consistently in both local and CI environments.
Member
Author
|
Last bit after this is removing the node adapter as the default adapter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.