Stop making clientIds and let LiveStore handle them#212
Merged
Conversation
Similar to anode PR #483, remove clientId generation from runt runtime agents. LiveStore will now handle clientId generation internally for device/app instances. - Remove clientId from RuntimeAgentOptions interface and RuntimeConfig class - Remove clientId from sync payload in runtime agent - Update auth.ts to stop generating clientIds in discoverUserIdentity() - Remove clientId parameter from PyodideRuntimeOptions - Update all tests to not pass clientId parameters - Remove obsolete clientId generation and validation tests User identity is still validated via JWT tokens, but client identification is now handled entirely by LiveStore's internal mechanisms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to anode PR #483, remove clientId generation from runt runtime agents. LiveStore will now handle clientId generation internally for device/app instances.
User identity is still validated via JWT tokens, but client identification is now handled entirely by LiveStore's internal mechanisms.