Fix dynamic bytes and string assertEq equality - #1163
Open
DicksonWu654 wants to merge 1 commit into
Open
Conversation
DicksonWu654
marked this pull request as ready for review
September 1, 2026 02:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bytesandstringpayloads as complete byte sequences with==KProblem
The dynamic
assertEqrules projected each decoded payload through#asWordbefore comparing it as an integer. Distinct ABI values can therefore collide:0x01and0x0001both project to integer1, allowing an unequalbytesorstringassertion to pass.Fix
Keep the ABI offsets and lengths as integers, but retain the decoded dynamic payloads as
Bytesand pass their full==Kequality result to#assert. This makes both content and length significant for thebytesandstringoverloads, including their message variants.Regression coverage
bytesvalues0x01and0x0001, with and without a message, are expected to failstringbyte sequences0x01and0x0001, with and without a message, are expected to fail0x0001values remain accepted for both types and both message formsValidation
git diff --check