fix(cheatcodes): preserve non-empty zero bytecode - #1165
Open
DicksonWu654 wants to merge 1 commit into
Open
Conversation
DicksonWu654
marked this pull request as ready for review
September 1, 2026 02:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vm.etch(..., hex"00")previously stored empty code because#setCodetreated any byte sequence with numeric value zero as empty. That changed the observable runtime from one byte to zero bytes, including code-size and code-hash results.This changes the normalization check to use
lengthBytes(CODE) ==Int 0, preserving actual empty code while retaining every non-empty byte sequence.The regression test
AccountParamsTest.testEtchEmptyAndZero()checks both empty bytes and the one-byte zero runtime, and is registered infoundry-prove-all.Testing
Tests were not run locally under the review constraint; upstream CI can execute the regression.