Update to rapidhashV3 family of functions - #321
Open
Nicoshev wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
@rurban 🤗 |
There was a problem hiding this comment.
Pull Request Overview
The PR updates the rapidhash test suite to use the new v3 implementation and introduces two new variants (Micro and Nano) both in the test registry and in their rapidhash_*_test functions.
- Swapped out the v1 implementations in
main.cppfor v3 and added entries for Micro and Nano. - Modified
rapidhash_testto callrapidhash_withSeedand addedrapidhashMicro_testandrapidhashNano_testinHashes.h.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| main.cpp | Updated hash registry: replaced v1 with v3 entry, added Micro and Nano variants with new CRC values. |
| Hashes.h | Pointed rapidhash_test to the new v3 API and added inline tests for Micro and Nano variants. |
Comments suppressed due to low confidence (3)
main.cpp:783
- [nitpick] The description for
rapidhashMicroduplicates the function name; consider providing a more descriptive label like "rapidhash micro variant" for clarity.
{ rapidhashMicro_test, 64, 0x5B61CB21, "rapidhashMicro", "rapidhashMicro", GOOD, {}},
main.cpp:784
- [nitpick] The description for
rapidhashNanorepeats its name; consider a clearer label such as "rapidhash nano variant" to differentiate it.
{ rapidhashNano_test, 64, 0x8F36208E, "rapidhashNano", "rapidhashNano", GOOD, {}},
Hashes.h:669
- The
objsizecomment here was for the unrolled version; update it to reflect the actual size of the Nano variant.
// objsize: 18420-1872e: 782
Contributor
Author
|
@rurban Any update? :) |
|
Also interested in this 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to rapidhashV3:
rapidhash test now runs rapidhashV3
Added rapidhashMicro and rapidhashNano
More on the family of functions can be found at: https://github.com/Nicoshev/rapidhash