Skip to content

Update to rapidhashV3 family of functions - #321

Open
Nicoshev wants to merge 4 commits into
rurban:masterfrom
Nicoshev:rapidhashV3
Open

Update to rapidhashV3 family of functions#321
Nicoshev wants to merge 4 commits into
rurban:masterfrom
Nicoshev:rapidhashV3

Conversation

@Nicoshev

Copy link
Copy Markdown
Contributor

Update to rapidhashV3:

rapidhash test now runs rapidhashV3
Added rapidhashMicro and rapidhashNano

More on the family of functions can be found at: https://github.com/Nicoshev/rapidhash

@Nicoshev

Copy link
Copy Markdown
Contributor Author

@rurban 🤗

@rurban rurban self-assigned this May 29, 2025
@rurban
rurban requested a review from Copilot May 29, 2025 03:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR updates the rapidhash test suite to use the new v3 implementation and introduces two new variants (Micro and Nano) both in the test registry and in their rapidhash_*_test functions.

  • Swapped out the v1 implementations in main.cpp for v3 and added entries for Micro and Nano.
  • Modified rapidhash_test to call rapidhash_withSeed and added rapidhashMicro_test and rapidhashNano_test in Hashes.h.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
main.cpp Updated hash registry: replaced v1 with v3 entry, added Micro and Nano variants with new CRC values.
Hashes.h Pointed rapidhash_test to the new v3 API and added inline tests for Micro and Nano variants.
Comments suppressed due to low confidence (3)

main.cpp:783

  • [nitpick] The description for rapidhashMicro duplicates the function name; consider providing a more descriptive label like "rapidhash micro variant" for clarity.
{ rapidhashMicro_test,          64, 0x5B61CB21, "rapidhashMicro", "rapidhashMicro", GOOD, {}},

main.cpp:784

  • [nitpick] The description for rapidhashNano repeats its name; consider a clearer label such as "rapidhash nano variant" to differentiate it.
{ rapidhashNano_test,          64, 0x8F36208E, "rapidhashNano", "rapidhashNano", GOOD, {}},

Hashes.h:669

  • The objsize comment here was for the unrolled version; update it to reflect the actual size of the Nano variant.
// objsize: 18420-1872e: 782

Comment thread Hashes.h
@Nicoshev

Copy link
Copy Markdown
Contributor Author

@rurban Any update? :)

@Sewer56

Sewer56 commented Jul 23, 2025

Copy link
Copy Markdown

Also interested in this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants