Skip to content

fix for when filtering leads to no results#696

Merged
rusq merged 1 commit into
masterfrom
resume-skip-followup
May 23, 2026
Merged

fix for when filtering leads to no results#696
rusq merged 1 commit into
masterfrom
resume-skip-followup

Conversation

@rusq

@rusq rusq commented May 23, 2026

Copy link
Copy Markdown
Owner

Followup for #695

Fix slackdump resume when stale filters remove every resume candidate.

Previously, a valid database archive could be reported as empty if -skip-stale-threads or -skip-stale-channels filtered out all generated resume
entities. The command now treats that case as a successful no-op and returns before Slack API setup.

Changes

  • Changed latest(...) to return a small result struct with:
    • the generated entity list
    • whether the source had latest timestamp data
    • how many entities were skipped by stale cutoffs
  • Added resume exit decision logic to distinguish:
    • truly empty archives
    • fully stale-filtered archives
    • non-empty resume selections
  • Preserved explicit CLI entity overlays so user-provided entities still force work.
  • Added an info log for fully stale-filtered no-op runs.
  • Documented the no-op behavior in resume help.
  • Expanded resume tests for stale-filtered empty results and decision behavior.

Tests

  • go test ./cmd/slackdump/internal/resume

@rusq rusq merged commit 3c59a8a into master May 23, 2026
4 checks passed
@rusq rusq deleted the resume-skip-followup branch May 23, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant