Allow remote desktop sharing to work again on Linux #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git commit 882d8cf fixed a problem where restarting a snapshot that had open worlds would fail on Linux due to using the fully qualified display name. Unfortunately it broke support for sharing worlds on other displays - they would always open on the local display. The fix backs out that change so that remote displays work and fixes the original issue by using the default display name.
doublec
force-pushed
the
linux_remote_display
branch
from
585d816 to
5f6acda
Compare
Collaborator
Author
|
Rebased on top of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git commit 882d8cf fixed a problem where restarting a snapshot that
had open worlds would fail on Linux due to using the fully qualified
display name. Unfortunately it broke support for sharing worlds on
other displays - they would always open on the local display.
The fix backs out that change so that remote displays work and fixes
the original issue by using the default display name.
This can be tested by starting an additional Xserver like Xnest:
Then from within Self on the local display grab a 'Share window with' Morph from the factory onto the desktop. Enter '127.0.0.1:1.0' and press 'share window with'. The Xnest will now show a Self desktop and you can see the other user.
Prior to this patch the desktop would always spawn in a new window on the local display regardless of the display name used.
Saving the snapshot, exiting, then restarting correctly opens the windows on the local display.