Sparc prettify and comment some asm sources (same object code) #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two columns layout for delay slots is very idiosyncratic. Instead use the standard convention to indent the delay slot one extra space. Use synthetic inc/dec for readability.
Two columns layout for delay slots is very idiosyncratic. Instead use the standard convention to indent the delay slot one extra space. Use synthetic inc/dec for readability. Wrap return sequences into macros. When they are not cluttering the view, the rest of the structure is easier to see. Comment vectorfind_next_match_1 in details, the rest of them have the same structure, just more targets to check. include "_enum_sparc.S.incl" - this code used to be in enum_sparc.S, so pretend it still is and get our asmDefs.hh via its incl file. Same object code is generated.
The one exception to the same object code is a "set" that was spelled in the original as sethi/add instead of sethi/or.
nbuwe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.