Fix build on MacOS X/PowerPC #169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old MacOS X doesn't define the former in the 10.5 SDK.
Apple uses @ as the command separator and ; as the comment, so we have to hide that behind a macro too, *sigh*. Yes, technically "__" is a reserved name, but we can get away with it and its not as ugly as anything with alphanumerics in it.
Add unconditionally only the flags that MacOS X 10.5 gcc 4.2 accepts. Add other flags (that said 4.2 does not accept) based on the compiler version. The versions were picked from inspecting the gcc docs and should not be too wrong, hopefully.
Doesn't matter on case-insensitive macos, but keep things tidy.
Contributor
Author
|
1b7d1a4 should deal with automated architecture/sdk selection. Not tested on an actual Intel Mac since I don't have a Mojave image handy, but I tried to make sure the i386 branch should end up with the same values as the old hardcoded ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on 10.5.8.
One missing change is thatvm/cmake/mac_osx.cmakehardcodes i386. For the test I have hardcoded ppc instead:My cmake-fu is not up to doing it properly, help appreciated.