Fix property sheet error from not finding labelMorph font #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Added a commit that fixes issue #4 on Mac OS X. |
When getting the property sheet of a labelMorph that is using a font that doesn't exist in the 'x11Globals scalableFont' list an error occurs and the property sheet can't display. The scalableFont list has an undefinedSelector method which handles direct requests for fonts that don't exist and returns 'times'. Unfortunately the enumeration of the fonts that the property sheet uses just lists the selectors of 'fontFamily' so treats the undefinedSelect method as a font name and hence the default handlin never occurs. This fix taken here adds a 'defaultFont' to the scalableFont list. This returns 'times', the same as the undefined selector. The property sheet looks this up if the actual font name can't be found. I also remove the undefined selector slot name and a couple of other non-font slots that were missed in the x11Globals fontFamily method.
This fixes russellallen#4. On Mac OS X the 'scalableFont' property does not exist in the windowCanvas for quartz. This adds it by falling back on the X11 implementation. This commit also adds a 'verdana' font entry to the list of X11 fonts allow Verdana to display and be selected in the property sheet. On Mac OS X this correctly results in Verdana displaying. On Linux without Verdana it falls back to the default, Times.
doublec
force-pushed
the
label_property_sheet
branch
from
07a8704 to
375e4b2
Compare
Collaborator
Author
|
Rebased on top of master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When getting the property sheet of a labelMorph that is using a font
that doesn't exist in the 'x11Globals scalableFont' list an error
occurs and the property sheet can't display.
The scalableFont list has an undefinedSelector method which handles
direct requests for fonts that don't exist and returns 'times'.
Unfortunately the enumeration of the fonts that the property sheet
uses just lists the selectors of 'fontFamily' so treats the
undefinedSelect method as a font name and hence the default handlin
never occurs.
This fix taken here adds a 'defaultFont' to the scalableFont list.
This returns 'times', the same as the undefined selector. The
property sheet looks this up if the actual font name can't be found.
I also remove the undefined selector slot name and a couple of other
non-font slots that were missed in the x11Globals fontFamily method.
See issue 4 for other details. I didn't relate this to issue 4 as that issue may be a Mac OS X backend problem.