Update certificate validation to support certificate chains#192
Open
ashpaw95 wants to merge 1 commit intorussellhaering:mainfrom
Open
Update certificate validation to support certificate chains#192ashpaw95 wants to merge 1 commit intorussellhaering:mainfrom
ashpaw95 wants to merge 1 commit intorussellhaering:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
verifyCertificatefunction now usesx509.VerifyOptionsto perform proper certificate chain validation.It extracts the leaf certificate and any provided intermediate certificates from the
KeyInfoand verifies the chain against a pool of trusted root certificates.This addresses issues where validation would fail if only the leaf certificate was provided without the rest of the chain.