Handle when IDP does not use namespace prefix on CanonicalizationMethod#36
Open
james-async wants to merge 2 commits intorussellhaering:mainfrom
Open
Handle when IDP does not use namespace prefix on CanonicalizationMethod#36james-async wants to merge 2 commits intorussellhaering:mainfrom
james-async wants to merge 2 commits intorussellhaering:mainfrom
Conversation
Owner
|
Good find, you uncovered some old code that has an actual bug in it. That Can you test this branch and confirm that it fixes the issue for you? https://github.com/russellhaering/goxmldsig/tree/russell_h/improved_namespace_handling_2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Novell Access Manager" does not put a namespace prefix on the CanonicalizationMethod element. (or at least the installed version we are working with does not). We tried to write a test. This is a minimalist change rather than changing
childPath.In fact the official documentation shows that the namespace prefix is not applied to CanonicalizationMethod.
https://www.netiq.com/documentation/access-manager-43/admin/data/b65ogn0.html
<ds:SignedInfo> <CanonicalizationMethod xmlns="http://www.w3.org/2000/09/xmldsig#" Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/> <ds:SignatureMethod Algorithm="http://www.w3.org/2000/09/xmldsig#rsa-sha1"/> <ds:Reference URI="#idF5JceWGWYwS3bOkmJS2wJuNqitU"> <ds:Transforms> <ds:Transform Algorithm="http://www.w3.org/2000/09/xmldsig#enveloped-signature"/> <ds:Transform Algorithm="http://www.w3.org/2001/10/xml-exc-c14n#"/> </ds:Transforms> <ds:DigestMethod Algorithm="http://www.w3.org/2000/09/xmldsig#sha1"/> <DigestValue xmlns="http://www.w3.org/2000/09/xmldsig#">ZocFiEUYcda0cKGRNcZYZqvmnlM=</DigestValue> </ds:Reference> </ds:SignedInfo>