Cover the prefetch timeout-takeover race; harden range-GET validation#45
Merged
Merged
Conversation
When a demand read waits on an in-flight full-group prefetch, hits the wait_for_group deadline, and takes over with its own seekable range GET, a later-completing stale prefetch must not overwrite the foreground's fresh frame. Add a deterministic test that drives exactly that race — stale full GET still pending, replay epoch advanced, foreground takeover serving fresh range bytes — and asserts the fresh frame wins and the stale full GET is cancelled. Also extract validate_range_get_result and extend its test to reject both short and overlong range responses (was overlong only). Full tiered suite green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small, durable pieces:
wait_for_groupdeadline, and takes over with its own range GET, a later-completing stale prefetch must not overwrite the fresh foreground frame. Adds a deterministic test driving that race (stale full GET pending, replay epoch advanced, foreground serving fresh range bytes) and asserts the fresh frame wins and the stale GET is cancelled. This is the only deterministic coverage of that takeover path.validate_range_get_resultand extend its test to reject both short and overlong range responses (was overlong only).Full tiered suite green (588).
🤖 Generated with Claude Code