Add current_url to request - #67
Merged
notriddle merged 1 commit intoMar 22, 2026
Merged
Conversation
Contributor
Author
|
Marking as draft so that I can test with WPT on Servo and ensure we cover all cases correctly now. |
The specification uses two different URLs: the url and the current URL. The distinction is relevant when redirecting [1]. When we report a violation, we should use the original URL that started the request. However, all checks on URLs then need to use the current URLs. This ensures that after a redirect, the new URL is then checked against the CSP policy. This is extensively tested by WPT, see the results in the corresponding Servo PR [2]. [1]: https://w3c.github.io/webappsec-csp/#create-violation-for-request [2]: servo/servo#43438
TimvdLippe
force-pushed
the
add-request-current-url
branch
from
March 18, 2026 21:59
6ae77c9 to
d469f3b
Compare
TimvdLippe
marked this pull request as ready for review
March 19, 2026 06:26
Contributor
Author
|
Test results look good. After merging, can you publish 0.7.0 for this? Thanks! |
Member
|
Okay, the release is pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specification uses two different URLs: the url and the current URL. The distinction is relevant when redirecting 1. When we report a violation, we should use the original URL that started the request. However, all checks on URLs then need to use the current URLs. This ensures that after a redirect, the new URL is then checked against the CSP policy.
This is extensively tested by WPT, see the results in the corresponding Servo PR 2.