Implement frame-ancestors directive - #69
Conversation
This requires implementing the navigation response check, which is only partially implemented. Even though the spec has a step 3 to check the navigation request, there is no directive that checks for it. Also, the logic for traversing navigable isn't possible in this crate. Instead, the caller is expected to pass in the list of origins as URLs, so that this crate can loop over them.
|
Thanks once again! Can you publish 0.7.1 so that I can update our version in Servo? |
|
Ah and in that case, #70 can also be included. Coincidentally found that while working on a different issue. |
|
@notriddle sorry to keep on bothering you. Unfortunately for Servo we need a new release of the crate before we can use it. Typically we update the crate with some fixes and improved WPT tests. Then we find new fixes that potentially require more updates to the crate. Previously we used a git fork for rapid iteration and then to upstream. However, the updates had stopped at the time and we no longer want git dependencies. That's because there are plans to publish Servo itself as a crate. Therefore, for now we require crate publications after fixes so that we can pull them in. Can you publish 0.7.1 and let us know what your thoughts are on the process? |
|
Okay, it's pushed. |
2 participants
This requires implementing the navigation response check, which is only partially implemented. Even though the spec has a step 3 to check the navigation request, there is no directive that checks for it.
Also, the logic for traversing navigable isn't possible in this crate. Instead, the caller is expected to pass in the list of origins as URLs, so that this crate can loop over them.