Add waitforblock, waitforblockheight and waitfornewblock
#388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hidden module had a copy-paste error and stated it was for the generating section. Update the documentation to state that the methods are hidden and not shown in the COre API docs.
blockchain__get_tx_out_proof__modelled is identical to blockchain__verify_tx_out_proof__modelled, and the method gettxoutproof is tested above in blockchain__get_tx_out_proof. Remove the redundant test.
The model part of the verify_tx_out_proof test was in it's own function that the test function called. Other tests all check the model in the same test. Combine them into one function. Place it in the correct location. Remove associated import.
jamillambert
force-pushed
the
1016-wait-for-block
branch
from
cbfde5b to
2edb0b5
Compare
|
Converting to draft to fix CI test fail that does not happen locally. Actually it does occur locally, I only checked 17 and 30. For some reason only v23-26 fail. Update: Problem fixed, although I don't understand why it only affected v23-26. |
Add waitforblock, waitforblockheight and waitfornewblock methods to v17. They are hidden until v30 with no changes.
jamillambert
force-pushed
the
1016-wait-for-block
branch
from
2edb0b5 to
6a684dc
Compare
|
The three RPCs have the same return shape. I made 3 seperate types since they only have a block hash and height in them it made no sense to have a seperate internal type that only has those 2 values in it. I considered having one type e.g. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waitforblock,waitforblockheightandwaitfornewblockwere added to the Core API docs in v30 under blockchain. The RPCs have been there since before v17.Add the RPCs to v17, and add to the types table in v30.
generatingsection.hidden.blockchain__get_tx_out_proof__modelledis identical toblockchain__verify_tx_out_proof__modelled, and the methodgettxoutproofis tested above inblockchain__get_tx_out_proof.verify_tx_out_prooftest was in it's own function that the test function called. Other tests all check the model in the same test.waitforblock,waitforblockheightandwaitfornewblockmethods to v17. They are hidden until v30 with no changes.