Repository navigation
feat(progress): Detect OSC 9;4 in multiplexers tmux and Herdr - #372
Merged
Merged
Conversation
epage
reviewed
Nov 5, 2026
Recognize tmux 3.7+ through TERM_PROGRAM and TERM_PROGRAM_VERSION, including patch suffixes such as 3.7b. Recognize Herdr by TERM_PROGRAM. tmux exposes progress to status formats and emits it to clients with Spb, supplied by terminfo, built-in mappings, or configuration. Automatic Ghostty progressbar recognition requires tmux 3.8. Herdr consumes progress for agent detection, not a generic visible bar. These hints work in native and remote panes without probing. Preserve the TTY gate and document detection inputs. Test tmux version parsing directly, covering boundaries, patch suffixes, malformed values, and overflow.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to solve?
Supporting common multiplexers: Recognize
tmux3.7+ through TERM_PROGRAM and TERM_PROGRAM_VERSION, including patch suffixes such as 3.7b, recognizeHerdrby TERM_PROGRAM, list already supportedcmuxand the status ofscreen+Zellij(missing upstream support).tmux exposes progress to status formats and emits it to clients with Spb, supplied by terminfo, built-in mappings, or configuration. Automatic Ghostty progressbar recognition requires tmux 3.8. Herdr consumes progress for agent detection, not a generic visible bar.
These hints work in native and remote panes without probing. Preserve the TTY gate and document detection inputs. Test tmux version parsing directly, covering boundaries, patch suffixes, malformed values, and overflow.
Notes to reviewers
LLM involvement: No. Manually inspected and tested all listed multiplexers (cmux, herdr, screen, tmux, zellij) locally and remote via ssh and composed the documented context, conditionals, and parsing.