Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checking for #[unsafe(no_mangle)] and #[inline(never)] in the ?godbolt command #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

HomelikeBrick42
Copy link

What the title says, im not sure if #[inline(never)] should be mentioned or if its too long

@bend-n
Copy link

bend-n commented Mar 8, 2025

ive been thinking about making a pr to actually insert #[unsafe(no_mangle)] in cases of pub fn, could we do that instead?

@HomelikeBrick42
Copy link
Author

would it just a simple search-replace? and would there be some way to turn it off?

@bend-n
Copy link

bend-n commented Mar 8, 2025

well we have syn parsing the input already so we would use syn, and i dont see why we need to have it be turn-offable?

@HomelikeBrick42
Copy link
Author

HomelikeBrick42 commented Mar 8, 2025

there could potentially be linking conflicts if you had multiple mods or something with pub fns in them, but tbh those should be easy to work around and people arent likely putting stuff that complex into the ?godbolt command anyways

@bend-n
Copy link

bend-n commented Mar 8, 2025

yeah so do you want to implement that or should i?

@HomelikeBrick42
Copy link
Author

i could try implementing it, should it be the same pr or a new one?

@bend-n
Copy link

bend-n commented Mar 8, 2025

should replace this pr i think, we can get rid of the note completely if we do that.

@HomelikeBrick42
Copy link
Author

finally remembered to actually do it #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants