Filter unsupported -Wp,-U preprocessor args for zig cc#420
Merged
Conversation
messense
force-pushed
the
fix-wp-u-fortify-source
branch
from
3b164fb to
b21ce26
Compare
messense
force-pushed
the
fix-wp-u-fortify-source
branch
from
b21ce26 to
9aed455
Compare
zig cc doesn't support the `-Wp,-U` pass-through form (e.g. `-Wp,-U_FORTIFY_SOURCE` added by CMake). Strip these args in `filter_linker_arg` to fix builds of crates like `aws-lc-sys` that use CMake internally.
messense
force-pushed
the
fix-wp-u-fortify-source
branch
2 times, most recently
from
c175295 to
c8b127c
Compare
messense
force-pushed
the
fix-wp-u-fortify-source
branch
from
c8b127c to
391242d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zig cc doesn't support the
-Wp,-Upass-through form (e.g.-Wp,-U_FORTIFY_SOURCEadded by CMake). Strip these args infilter_linker_argto fix builds of crates likeaws-lc-systhat use CMake internally.