Skip to content

start adding argument and response module#232

Open
robamu wants to merge 1 commit intorust-embedded-community:developfrom
robamu:argument-response-module
Open

start adding argument and response module#232
robamu wants to merge 1 commit intorust-embedded-community:developfrom
robamu:argument-response-module

Conversation

@robamu
Copy link
Copy Markdown
Contributor

@robamu robamu commented Mar 2, 2026

Nice types for SD mode arguments and responses using bitbybit

@robamu robamu force-pushed the argument-response-module branch from 2e7bd36 to 1ba799f Compare March 2, 2026 21:50
Comment thread src/sdcard/mod.rs Outdated
//==============================================================================

/// Argument module. Arguments are additional command parameters.
pub mod argument {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d rather have modules on disk instead of inline modules. I just it makes them easier to find in your editor?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that

@robamu robamu force-pushed the argument-response-module branch 2 times, most recently from c0d50f5 to b9d7961 Compare March 3, 2026 15:42
@thejpster
Copy link
Copy Markdown
Member

Looks good, but I see these types aren't yet used. Is there a plan to use them?

@robamu
Copy link
Copy Markdown
Contributor Author

robamu commented Mar 4, 2026

for now, these can be used for implementing SD drivers in separate crates. Implementing a generic SD driver which use these inside the library could work, but a generic transport trait to send CMDs/ACMDS is required first and I am not fully sure how well that works.

@robamu robamu force-pushed the argument-response-module branch 3 times, most recently from d322f44 to 9300e6a Compare March 9, 2026 15:36
@robamu robamu force-pushed the argument-response-module branch from 9300e6a to f1bb923 Compare March 29, 2026 21:28
@robamu robamu requested a review from thejpster March 29, 2026 21:30
@robamu robamu force-pushed the argument-response-module branch 2 times, most recently from b88fa22 to 1320605 Compare April 1, 2026 12:35
@robamu robamu force-pushed the argument-response-module branch from 1320605 to d5b63d9 Compare April 1, 2026 12:36
@robamu
Copy link
Copy Markdown
Contributor Author

robamu commented Apr 1, 2026

rebased again

Comment thread src/sdcard/argument.rs
MaximumPerformance = 1,
}

/// HPC.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HPC?

@thejpster
Copy link
Copy Markdown
Member

Looks ok, but I think we need some kind of example to show how to use them. How hard would it be to build a fake SD Card with an API to send requests and get responses that an example can drive in a similar way to how you would initialise an actual SD Card?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants