Skip to content

Conversation

@williamdes
Copy link
Contributor

Hi! Thank you for helping out with SSD1306 development! Please:

  • Check that you've added documentation to any new methods
  • Rebase from master if you're not already up to date
  • Add or modify an example if there are changes to the public API
  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • Run rustfmt on the project with cargo fmt --all - CI will not pass without this step
  • Check that your branch is up to date with master and that CI is passing once the PR is opened

PR description

I noticed that 64x32 was missing in prelude

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, thanks.
Could you also:

  • Add a CHANGELOG.md entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)
  • Run rustfmt on the project with cargo fmt --all - CI will not pass without this step

@williamdes
Copy link
Contributor Author

Sounds good to me, thanks.

Thank you for the quick review, I will clone the repo and process this soon

@williamdes williamdes requested a review from eldruin February 9, 2025 18:28
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I will add it to the changelog myself.

@eldruin eldruin merged commit a99be96 into rust-embedded-community:master Mar 22, 2025
11 checks passed
eldruin added a commit that referenced this pull request Mar 22, 2025
@williamdes williamdes deleted the patch-1 branch March 22, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants