update dependencies (primary goal: defmt v1.0) & use defmt again in lib
#61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`defmt` released v1.0 and used the semver trick (releasing v0.3.100) to make updating to it non-breaking.
this was intentionally done in a separate commit to make it clear that the library update is non-breaking.
rursprung
commented
Apr 8, 2025
This was referenced Apr 8, 2025
rursprung
changed the title
defmt v1.0)defmt v1.0) & use defmt again in lib
jannic
reviewed
Apr 9, 2025
i had forgotten to completely remove the dependency in the now reverted commit, thus the optional dependency still created a feature which consuming crates could enable. removing it would be a breaking change. this leaves two options: * remove the `defmt` _dependency_ and add a dummy _feature_ of the same name, issuing a compile warning if it is enabled, eventually removing it in v2.0 if or when that will ever be released * accept the fact that we already have the optional dependency and thus the feature and make use of it this contains a few changes to the reverted commit: * the feature is now called `defmt` rather than `defmt-03` (as that's the name of the implicit feature for the optional dependency) * the `debug` output in `drive` is kept but downgraded to `trace` and slightly reworded (the speed is already present in the command) * the `cfg`-guarded `use` is removed to make the code cleaner This reverts commit d9da807. (with minor adaptations)
rursprung
force-pushed
the
dependency-updates
branch
from
e8072bf to
0d014af
Compare
jannic
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please see the individual commit messages!
doing this manually rather than letting dependabot take care of it to document that this is a non-breaking change.
due to the semver trick there's also no need to release a new version of the crate immediately.
also please note that that the
defmtdependency was unused; i've re-introduced the usage since it was already present and thus offered a feature for consumers to enable (removing which would've been a breaking change)