asm instructions only available for cortex-a and cortex-r#46
Conversation
jonathanpallant
left a comment
There was a problem hiding this comment.
Should we gate the asm inside the function, or the function itself? This PR does either, randomly.
|
I guess I can gate all the functions. For some reason, cortex-m gated the asm inside the function for the |
|
the asm module is already feature gated, just did not see it. But maybe the feature gate can be made cortex-ar specific? |
|
What host were you on? |
|
x86_64 |
|
Then the module shouldn't be compiled? |
|
Yes. I think that was a mistake on my side (I was able to solve the issue since then). I think this can be closed. Do you think a cortex-a/r specific feature gate would be useful? it would prevent using them on cortex-m, but cortex-m and cortex-ar assembler routines look really similar |
|
I don't think we need to worry about someone using cortex-ar on cortex-m. |
I had a transitive dependency to cortex-ar for an auto-generator tool, and the assembler instructions were problematic.
I introduced feature-gating, similary to how it is done in cortex-m