Skip to content

Epub download#39

Merged
eldruin merged 13 commits into
rust-embedded:mainfrom
martcpp:epub_download
Jul 17, 2025
Merged

Epub download#39
eldruin merged 13 commits into
rust-embedded:mainfrom
martcpp:epub_download

Conversation

@martcpp
Copy link
Copy Markdown
Contributor

@martcpp martcpp commented Jul 17, 2025

#34 added the epub-link.js to it and also add a download link to the mdbook
created a ci that that copy .epub file in the build to src/static which the mdbook build will use to create the link in html/static/Discovery.epub

Fixes #34

@martcpp martcpp requested a review from a team as a code owner July 17, 2025 02:09
Copy link
Copy Markdown
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!
It seems the dependencies between mdbook and mdbook-epub are strict to the patch level so let's fixate them.

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Comment thread mdbook/src/SUMMARY.md Outdated
Copy link
Copy Markdown
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and if there are any issues we can fix them then. Thanks again!

@eldruin eldruin merged commit 68fbe1c into rust-embedded:main Jul 17, 2025
3 checks passed
@BartMassey BartMassey mentioned this pull request Jul 17, 2025
@BartMassey
Copy link
Copy Markdown
Member

@eldruin Thanks! You are a few minutes ahead of me. 😀

I've filed issue #40 to get a few remaining fixes on the list. I've also filed PR #41 to give the book a decent title.

@martcpp Thanks huge for doing this!

@martcpp
Copy link
Copy Markdown
Contributor Author

martcpp commented Jul 17, 2025

I feel this CI pipeline will crash so it should be updated on my fork It was working. But not sure it will work here 🤔
@BartMassey @eldruin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mdbook-epub setup

3 participants