Skip to content

add link and missing blank (i did not build it to check)#71

Merged
BartMassey merged 4 commits into
rust-embedded:mainfrom
iampi31415:updated-link
Oct 22, 2025
Merged

add link and missing blank (i did not build it to check)#71
BartMassey merged 4 commits into
rust-embedded:mainfrom
iampi31415:updated-link

Conversation

@iampi31415

Copy link
Copy Markdown
Contributor

Closes #70

@iampi31415 iampi31415 requested a review from a team as a code owner October 21, 2025 13:55
@iampi31415 iampi31415 changed the title add link and missing blank add link and missing blank (i did not build it to check) Oct 21, 2025
@BartMassey

Copy link
Copy Markdown
Member

Link (and text) should be nrf52833-hal. Fixed: thanks much.

@BartMassey BartMassey closed this Oct 21, 2025
@iampi31415

iampi31415 commented Oct 21, 2025

Copy link
Copy Markdown
Contributor Author

Hi @BartMassey, that's not the issue I was pointing to, my PR is something else.

  1. microbit-v2 should be a link you do not have a link at all currently:
docs rust-embedded org_discovery-mb2_02-requirements_index html
  1. Plus, I was adding a missing blank elsewhere.

@BartMassey BartMassey reopened this Oct 21, 2025
@BartMassey

Copy link
Copy Markdown
Member

Ah sorry. Apologies. I'll take a look at this now.

@BartMassey BartMassey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link should be to https://docs.rs/microbit-v2 I think?

@iampi31415 iampi31415 requested a review from BartMassey October 21, 2025 18:13

@BartMassey BartMassey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be all nitpicky, but I don't think we want latest/microbit? docs.rs/microbit-v2 should take us to the right place. The whole situation with microbit and microbit-v2 crates is super-confusing; should look into CI for that.

@iampi31415

iampi31415 commented Oct 21, 2025

Copy link
Copy Markdown
Contributor Author

Sorry to be all nitpicky,

I don't mind at all.

we want latest/microbit? docs.rs/microbit-v2

Makes sense. However, https://docs.rs/microbit-v2/ automatically redirects to https://docs.rs/microbit-v2/latest/microbit/ but I did replace it anyways.

@iampi31415 iampi31415 requested a review from BartMassey October 22, 2025 13:12

@BartMassey BartMassey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BartMassey BartMassey merged commit 79a09ab into rust-embedded:main Oct 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is this a typo

2 participants