-
Notifications
You must be signed in to change notification settings - Fork 62
update examples #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
update examples #109
Conversation
c09f694 to
0f331ec
Compare
4984063 to
370336b
Compare
|
With #110 , I think the additional example is not required anymore. The heap memory blocks will be placed into .bss anyway. |
|
The shell script could be avoided by using knurling-rs/defmt#1012 if that is released... |
| [build] | ||
| # Common embedded build targets | ||
| target = "thumbv7em-none-eabihf" | ||
| # target = "thumbv6m-none-eabi" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove code, not comment out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the intention here was to simplify quickly switching between the thumv7em and thumbv6m default target, which are both used for tests/examples.
zeenix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the nitpick. The CI isn't going forward though. 🤔 Can you please rebase the branch and force push?
|
I am not sure what is going on with the CI. It is related to steps which were removed. Maybe this can be safely ignored? |
0198819 to
b0934a0
Compare
- Introduce `defmt` which is very commonly used on embedded systems. It is used to print the allocated structures. - New QEMU runner to support defmt. - Introduce new example which uses a global heap initialized on BSS memory. - Switch to more commonly used thumbv7em-none-eabihf target for the QEMU runner. thumbv6m-none-eabi is still supported as well.
b0934a0 to
de38e9e
Compare
|
I rebased and squashed. If you still prefer to have the quick switch option inside the config file removed, I can also do that. |
defmtwhich is very commonly used on embedded systems. It is used to print the allocated structures.