Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard DefaultHandler weak symbol with LTO #273

Closed
wants to merge 1 commit into from
Closed

Discard DefaultHandler weak symbol with LTO #273

wants to merge 1 commit into from

Conversation

ia0
Copy link
Contributor

@ia0 ia0 commented Mar 4, 2025

Fixes #247

@ia0 ia0 requested a review from a team as a code owner March 4, 2025 16:19
rmsyn
rmsyn requested changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@rmsyn rmsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks a number of builds.

Is there a reason you opened this over the fixes in #254?

@ia0
Copy link
Contributor Author

ia0 commented Mar 5, 2025

This breaks a number of builds.

Yes, I'm quite surprised. For my project it works both with and without LTO...

Is there a reason you opened this over the fixes in #254?

No, actually #254 also fixes my problem. Closing this in favor of #254.

@ia0 ia0 closed this Mar 5, 2025
@ia0 ia0 deleted the fix-247 branch March 5, 2025 08:37
@ia0 ia0 mentioned this pull request Mar 5, 2025
Open
@ia0
Copy link
Contributor Author

ia0 commented Mar 5, 2025

It might be compiler version related. So it's not reliable, sad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmsyn rmsyn rmsyn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

riscv-rt: Cannot be built with lto = true if the user defines replacement for .weak symbols
2 participants
@ia0 @rmsyn