Prevent Ferris from hiding code - #4540
Open
NeatNit wants to merge 1 commit into
Open
Conversation
Author
|
Just a note: I know there's a lot to clean up in the code, the reasons I didn't do that before submitting is I wanted to first get feedback on the result. The rendered result is pretty much complete. I will add screenshots to the OP in a few minutes. |
NeatNit
marked this pull request as draft
October 28, 2025 00:29
2 tasks
Author
|
Okay, I cleaned it up enough that it might be ready to publish. I'm removing the draft status, but I'll be happy to make changes if they're needed. |
NeatNit
marked this pull request as ready for review
October 28, 2025 15:25
NeatNit
force-pushed
the
ferris-scroll
branch
from
October 28, 2025 19:39
6e09fee to
26f9aed
Compare
nixxo
added a commit
to nixxo/rust-lang-book-it
that referenced
this pull request
Nov 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2893.
I am so very rusty with JavaScript and DOM manipulation. This was more painful to get done than I expected. But I think it was worth it.
The premise is simple: if Ferris is hiding some code, let the user scroll horizontally far enough until the code is no longer hidden. However, we don't want to create excessive scrolling unnecessarily.
THIS IS A DRAFT.To do:Before: Note that the horizontal scroll bar is at its limit.


After:
Before:


After: The longer line below Ferris is not given a margin unnecessarily.