Introduce CARGO_PKG_EDITION env var
#14873
Conversation
rustbot
added
A-build-execution
nyurik
force-pushed
the
pkg-lang-edition
branch
3 times, most recently
from
a759287 to
e7f96b4
Compare
|
As a heads up, our contribution process asks that issues be accepted before moving on to PRs. There are two directions to go and this direction has non-obvious problems to work through. We should work through this first before looking at the implementation. |
|
☔ The latest upstream changes (presumably 2560340) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
| /// The Rust language edition from the manifest of your package. | ||
| #[track_caller] | ||
| pub fn cargo_pkg_edition() -> Option<String> { |
There was a problem hiding this comment.
This should probably list MSRV information
There was a problem hiding this comment.
Looking at #14902, this should be
/// The Rust language edition from the manifest of your package.
#[doc = requires_msrv!("1.88")]
#[track_caller]
pub fn cargo_pkg_edition() -> String {
| @@ -239,6 +239,7 @@ corresponding environment variable is set to the empty string, `""`. | |||
| * `CARGO_PKG_REPOSITORY` --- The repository from the manifest of your package. | |||
| * `CARGO_PKG_LICENSE` --- The license from the manifest of your package. | |||
| * `CARGO_PKG_LICENSE_FILE` --- The license file from the manifest of your package. | |||
| * `CARGO_PKG_EDITION` --- The Rust language edition from the manifest of your package. | |||
There was a problem hiding this comment.
Should this also warn people about the deprecated behavior?
nyurik
force-pushed
the
pkg-lang-edition
branch
from
e7f96b4 to
1548a7e
Compare
|
@epage i rebased this PR. WRT your MSRV comments --- what kind of message do you think would be needed, and which version? Thx! |
Add
CARGO_PKG_EDITIONenvironment variable, allowing build scripts to determine the language edition of the crate being compiled.Fixes #14872
TBD - EnvVar Name
CARGO_PKG_EDITIONCARGO_PKG_RUST_EDITIONCARGO_PKG_LANG_EDITIONCARGO_PKG_LANGUAGE_EDITION