fix(clean): Clean hosts builds with new layout #16300
Open
+1,086
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
Command-clean
S-waiting-on-review
Collaborator
Contributor
Author
|
CC @ranger-ross |
weihanglo
reviewed
Nov 25, 2025
| let pkg_dir = format!("{}-*", pkg.name()); | ||
| clean_ctx.progress.on_cleaning_package(&pkg.name())?; | ||
|
|
||
| if clean_ctx.gctx.cli_unstable().build_dir_new_layout { |
Contributor
Author
There was a problem hiding this comment.
I duplicated clean.rs tests to verify -Zbuild-dir-new-layout. This uncovered several issues. I fixed most. There remains one which has test overlap with this so no test results changed. I decided to go ahead and get this update up rather than wait on all of them since this last one may be a bit nasty.
epage
force-pushed
the
clean
branch
2 times, most recently
from
12b9b45 to
0c3ed63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
When we have limited content do remove, we were cleaning in an inner loop and left off the host layout.
How to test and review this PR?
This is a follow up to #15947 that I noticed when looking at #16264.