Avoid console output for cargo script with unchanged builds#16389
Closed
Timmmm wants to merge 1 commit intorust-lang:masterfrom
Closed
Avoid console output for cargo script with unchanged builds#16389Timmmm wants to merge 1 commit intorust-lang:masterfrom
Timmmm wants to merge 1 commit intorust-lang:masterfrom
Conversation
Collaborator
Contributor
Author
|
Note I wasn't exactly sure what the significance of |
This adds a flag that records whether any work was actually done during a build (i.e. it is false for no-change builds). Then for 'manifest' commands, it suppresses some console output if the build was unchanged. This means that after the first time you run a `cargo script` and it's all cached, you only see output from the actual command; nothing from cargo (assuming your code has no warnings).
736339b to
298846a
Compare
Contributor
|
Note that our contrib docs discourage PRs until the issue has been accepted by the Cargo team Going to close for now until something is decided. We can always re-open if this PR is aligned with the agreed-to direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a flag that records whether any work was actually done during a build (i.e. it is false for no-change builds). Then for 'manifest' commands, it suppresses some console output if the build was unchanged.
This means that after the first time you run a
cargo scriptand it's all cached, you only see output from the actual command; nothing from cargo (assuming your code has no warnings).Fixes #16388
Testing
Hello.