feat(config): Add build.profile, install.profile - #17215
Open
epage wants to merge 3 commits into
Open
Conversation
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
A-cli
epage
marked this pull request as draft
July 14, 2026 20:23
rustbot
removed
the
S-waiting-on-review
epage
force-pushed
the
config-profile
branch
4 times, most recently
from
July 16, 2026 14:08
1127b1e to
2add9e9
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-author
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 7, 2026
### What does this PR try to resolve? Key points: - It inherits from `dev` - Conceptually, debugging is part of the development process - The hope is this will smooth out the transition for people - `cargo install --debug` now uses `debug` instead of `dev` - `debug` changes nothing from `dev` right now. `dev` will evolve in the future (with `debug` overriding those values to leave it effectively unchanged) but that is deferred out to offer a transition period where `debug` can be used without but isn't required for debugging as people deal with multiple Rust versions. This also shrinks the change and decouples what the conversation around what the settings should be. - `dev` still uses `target/debug`: this does not change any calculation for the transition cost and any conflicts between the profiles should mostly be in the artifact-dir (which are just hard links), especially once the new build layout lands - `--dev`/`--debug` flags are deferred out, needing more evaluation to decide if they are worth it See also https://github.com/rust-lang/cargo-team/blob/main/meetings/sync-meeting/2026-07-14.md#splitting-dev-and-debug-profiles ### How to test and review this PR? This is part of #15931 - `build.profile` will be a follow up (#17215) - `dev` profile changes are deferred for 1+ releases
This comment has been minimized.
This comment has been minimized.
epage
marked this pull request as ready for review
August 10, 2026 17:06
rustbot
added
the
S-waiting-on-review
epage
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
This adds
build.profileto smooth out the transition for #15931 by allowing users to change to thedebugprofile by default.This adds
install.profilebuild.profiledoes not applyHow to test and review this PR?
This is part of #15931
devprofile changes are deferred for 1+ releasesHow should
testandbenchbe handled? We went withcargo testhavingbuild.profileoverride the defaulttestso users will get consistent behavior betweencargo buildandcargo test. Alternatively, we could have told users to setprofile.test.inherits = "debug". Changing the inheritance is even less obvious though it is likely to run into fewer issues if projects change thetestprofile.