Add associated_ty_from_impl
to Chalk db to avoid computing associated types eagerly
#826
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we compute all associated types' values in
push_program_clauses_for_associated_type_values_in_impls_of
. This results in a cycle in rust-analyzer's implementation of RPITITs, since we need to be able to compute some associated type values before others. For example in:When solving for the hidden type of
fn fooI() -> impl Sized
, we need to be able to normalizeSelf::Assoc
before we know the value of the RPITIT infn foo() -> impl Sized
, which we are currently solving for :DThis PR adds
associated_ty_from_impl
, which will compute that the associated type that is actually the one we're assembling clauses for, rather than iterating through all associated types in the impl.This should break the cycle and should be reasonably easy to implement in chalk, though I'd like to know if this method would be difficult to implement: cc @ChayimFriedman2