Added labels to crate sidebar metadata#12746
Open
psg-19 wants to merge 2 commits intorust-lang:mainfrom
Open
Conversation
Member
|
why did you use visible labels instead of tooltips like some of the other metadata fields are using? |
Author
|
Thanks for the review. |
Member
yeah, but our tooltips are built in a way where clicking on the thing also displays the tooltips, so I'm not sure that comment actually applied. admittedly tooltips are still not a perfect pattern, but changing that is a bigger discussion, so in this case consistency seems more important for now. |
ff86cea to
3dce14f
Compare
3dce14f to
8152f4b
Compare
ce116de to
c087522
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #12668 by adding descriptive labels ("Last Updated" and "Size") to the metadata fields in the crate sidebar. This improves clarity for users by explicitly identifying what the date and byte values represent.