svelte: Implement /crates/[crate_id]/versions page
#12840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
the
C-enhancement ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This roughly matches the corresponding Ember.js route implementation, but it's using the SvelteKit
load()fn to load the initial set of versions and then a regular async fn to load additional pages. TheRowcomponent is also similar in terms of styling and behavior, but the API is slightly different since it accepts a rawversionobject, without a relationship to the corresponding crate or any derived properties.I've also included a Storybook file for the
Rowcomponent. Compare to the other Storybook files it only contains a single Story with all of the variations though. The reason for that is that I'm trying to reduce the number of snapshots that we use for visual regression testing, since that number is somewhat limited per month.